Skip to main content Help Control Panel

Login   A+   A-

Community «   Discussion forum «   Bug tracker «  

Security Problem with Comments - Need Fix Asap

avatarAnstey Stephan -- on Feb. 4
Comments on Associate only threads are exposed by the search engine.
Problem has been recorded

Issue description

When a member searches the site the results include comments by our members in theoreticaly secure threads.

Files

Comments.zip 10,668 bytes, 46 downloads
Edited by Dobliu on June 22
Zoom

Comments

AnsteyER
avatar
301 posts

on Feb. 4


I have commented out the code on search.php that searches the comments until this is resolved. If you want me to uncomment and show you my results, let me know.
  • verified that search was done logged completely out
  • verified that comments shown were in associate thread


The concern is that we often use the comments for sensitive private data.
Bernard
avatar
from nearby-an-airport
Associate, 6696 posts

on Feb. 7


Ok, I will do the same, and comment out the released code until a solution is find.
Dobliu
avatar
from L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
203 posts

on Feb. 10


Hello anteyER,

it's a major bug in YACS. Several months ago, i have posted a solution on French forum, due i think, a missing of time it was not reused in news releases. Code below in function search file comments.php; it is running with mysql version = or > v4.1, YACS 7.12 or 8.1,

Click to fold/unfold Click to fold/unfold

Bernard
avatar
from nearby-an-airport
Associate, 6696 posts

inspired from dobliu on Feb. 10


Dobliu: What is the minimum version of MySQL that supports combined SELECT statements such as the one you propose ?
Dobliu
avatar
from L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
203 posts

on Feb. 10


Bernard:
"subselect"  in Mysql  4.1, better compliance with SQL specifications.
Below 4.1, only  INSERT ... SELECT ...   and REPLACE ... SELECT ...,  but i have not checked .
I use mysql 5;  in others case  using   JOIN instruction  can be a solution.

 

 

Dobliu
avatar
from L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
203 posts

on Mar. 7


hello all

where is the search comment patch ?

Bernard, do you have a feeback on the suggested fix ?

is it in version 8.2 ?

bye ...

 

 

AnsteyER
avatar
301 posts

on Mar. 7


I am using mysql MySQL 5.0.24

are there any particular settings that might be wrong in my version?
AnsteyER
avatar
301 posts

inspired from ansteyER on Mar. 7


So i should find comment.php and replace the function there with this code?
Dobliu
avatar
from L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
203 posts

on Mar. 7


hello ansteyER :

do you have opened the folder  in  above comment  :

"Hello anteyER,

it's a major bug in YACS. Several months ago, i have posted a solution on French forum, due i think, a missing of time it was not reused in news releases. Code below in function search file comments.php; it is running with mysql version = or > v4.1, YACS 7.12 or 8.1,

 

Cliquer pour plier ou déplier Cliquer pour plier/déplier

"

Bernard
avatar
from nearby-an-airport
Associate, 6696 posts

on June 20


Dobliu, at the moment the core code of yacs does not allow for search requests in comments, nor in links, to preserve confidentiality.

If you wish, please provide an updated version of search.php and of related scripts, that could be integrated in July release.
Dobliu
avatar
from L'Île de Pâques (en espagnol Isla de Pascua, en rapanui Rapa Nui)
203 posts

on June 22


Dear YACSER'S,

Find attached this latest update of comments.php file  release 8.1. 

Don't forget to activate the search  in comments (search.php)

i am very busy during last days, and for the 8.5 release, i have not make a  revision.

Bye ...

 



comments.zip

Rate this page
Posted by AnsteyER on Feb. 4, commented by Dobliu on June 22, (popular)